Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage in MultilayerQG #32

Merged
merged 3 commits into from
Sep 11, 2019
Merged

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Sep 11, 2019

this PR adds a test for a 3-layer problem. This way line

for j = 2:nlayers-1
Qy[:, :, j] = @. beta - Uyy[:, :, j] - Fp[j]*( U[:, :, j+1] - U[:, :, j] ) - Fm[j-1]*( U[:, :, j-1] - U[:, :, j] )
end

is tested.

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #32 into master will increase coverage by 0.19%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   98.44%   98.63%   +0.19%     
==========================================
  Files           6        6              
  Lines         513      513              
==========================================
+ Hits          505      506       +1     
+ Misses          8        7       -1
Impacted Files Coverage Δ
src/multilayerqg.jl 96% <81.81%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab52d1...b683e7a. Read the comment docs.

@glwagner glwagner merged commit c3c4f2d into master Sep 11, 2019
@glwagner glwagner deleted the IncreaseCoverageMultilayerQG branch September 11, 2019 13:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 277

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.635%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/multilayerqg.jl 9 11 81.82%
Totals Coverage Status
Change from base Build 270: 0.2%
Covered Lines: 506
Relevant Lines: 513

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants