Plots replace PyPlot in TwoDNavierStokes examples #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
approved these changes
May 16, 2020
glwagner
reviewed
May 16, 2020
| @@ -25,13 +25,13 @@ nothing # hide | |||
| # | |||
| # First, we pick some numerical and physical parameters for our model. | |||
|
|
|||
| n, L = 128, 2π # grid resolution and domain length | |||
| n, L = 256, 2π # grid resolution and domain length | |||
glwagner
reviewed
May 16, 2020
| nsteps = 4000 # total number of steps | ||
| nsubs = 1000 # number of steps between each plot | ||
| dt = 5e-3 # timestep | ||
| nsteps = 8000 # total number of steps |
There was a problem hiding this comment.
This may be a pretty heavy example for docs. But we'll see how long they take to build; maybe it will be fine.
There was a problem hiding this comment.
128 would work OK also... but 256 looks better.
The problem will arise when we make all examples producing 256^2 animations...
navidcy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 98.62% 98.63%
=======================================
Files 6 6
Lines 510 511 +1
=======================================
+ Hits 503 504 +1
Misses 7 7
Continue to review full report at Codecov.
|
navidcy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning. We should ultimately drop PyPlot from docs/examples whatsoever.