Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for owner password #37

Merged
merged 1 commit into from
May 19, 2024
Merged

add support for owner password #37

merged 1 commit into from
May 19, 2024

Conversation

novag
Copy link
Contributor

@novag novag commented Jan 28, 2024

  • Allow specifying an owner password when creating the SRK

agent/agent.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
@novag
Copy link
Contributor Author

novag commented Feb 2, 2024

Thanks for the very quick review! Unfortunately, I've only now found the time to address the review.

@Foxboron
Copy link
Owner

Foxboron commented Feb 4, 2024

Still missing a test to check that ownerpassword actually works for the key loading. But I can write that up if you dont want to figure out how.

@novag
Copy link
Contributor Author

novag commented Apr 1, 2024

Thanks! I will push the test soon. However, this PR is blocked until google/go-tpm#357 is merged.

@Foxboron
Copy link
Owner

Foxboron commented Apr 1, 2024

Currently away so won't review this until later this weeks, but why do you need HierarchyChangeAuth for this change?

@novag
Copy link
Contributor Author

novag commented Apr 1, 2024

It's required to set an initial owner password for the test. Or is there another way that I am not aware of to initialize the TPM simulator with an owner password?

@Foxboron
Copy link
Owner

Foxboron commented Apr 1, 2024

Ah, this makes sense :)

I haven't read the complete TPM spec and stuff I do is very much me learning as a I go. I haven't messed around with owner password so you are probably correct.

@novag
Copy link
Contributor Author

novag commented Apr 2, 2024

I haven't read the whole spec either, but I'm pretty sure there's no other command for it. Thanks for your quick reply! :)

@Foxboron
Copy link
Owner

Please do tell me if the go-tpm patches takes too much time for you. I'd rather have this merged without a test then having it go stale because you are not able to work on the go-tpm patch :)

cmd/ssh-tpm-agent/main.go Outdated Show resolved Hide resolved
* Allow specifying an owner password when creating the SRK
@Foxboron
Copy link
Owner

LGTM.

Thanks for working on this :)

@Foxboron Foxboron merged commit 1c7bced into Foxboron:master May 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants