-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HierarchyChangeAuth command #357
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
79315e1
to
9cc6eac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! I had a couple of minor comments, otherwise looks ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! In which cases would you want the t.Fatal to be a t.Error?
To be more precise, I think lines 31, 45, and 62 in |
see definition in Part 3, Commands, section 24.8
Thank you @novag for the change and for the updates in response to my minor feedback items! |
see definition in Part 3, Commands, section 24.8
see definition in Part 3, Commands, section 24.8