-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick Order Form bug fixes and improvements #11
Labels
Comments
brettflorio
added
bug
Something isn't working
enhancement
New feature or request
labels
Sep 22, 2020
ndvo
added a commit
that referenced
this issue
Sep 23, 2020
Inconsistencies with the "quick order form" naming. addresses topic Inconsistencies in naming from issue #11
ndvo
added a commit
that referenced
this issue
Sep 23, 2020
The items property of the component can be used to both set and get the values of the items. Values are returned as a JS object. re #11
Thumbnail Display Options: @dantothefuture implemented this feature. at d946ddf. Adding a checklist to ease keeping track of this.
|
ndvo
added a commit
that referenced
this issue
Sep 24, 2020
avoid failing submission due to CORS issues addresses issue #11
ndvo
added a commit
that referenced
this issue
Sep 24, 2020
ndvo
added a commit
that referenced
this issue
Sep 24, 2020
Addresses issue #11, default target and cart parameters
ndvo
added a commit
that referenced
this issue
Sep 24, 2020
items should default to quantity 0, not 1. Items with zero qty are not to be considered invalid. addresses issue #11
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consistency in naming
There are a few inconsistencies with the "quick order form" currently. Let's tidy them up with the following:
foxy-items-form
. (We likefoxy-products-form
better but for consistency with the API, let's keepitems
or @brettflorio will hate it.)products
property on the component should change toitems
.Consistency in Data?
Currently, items added as
<foxy-item />
elements don't show up in the.products
property of the element (which we'll rename to.items
, per above). Can we make this work? I realize they might be technically different, but I'd "expect" for<foxy-item />
elements to be in theitems
property, as well as vice versa. Though I realize perhaps that might not actually make sense from a DOM + JS perspective, as they aren't the same things.QuickOrder#submit
fails due to CORSWe can't (currently) do a POST to the
/cart
endpoint, as we don't support CORS. For now, just make this do a normal POST to/cart
.Default
cart=checkout
parameterAdd
cart="checkout"
as a default parameter. Valid options arecheckout
, empty/null, andadd
(which is the same as empty/null). By default, this page should send the customer to the checkout.Default Subscription Parameters
Add
sub_modify="replace"
andsub_restart="auto"
to the output. Allow them to be overridden with empty values or as here: https://wiki.foxycart.com/v/2.0/products/subscriptions#subscription-related_product_options.Default
target
parameterSame as #6. This component may be used inside an iframe (like in Wix), and it should work by default there.
Default to quantity=0
I think we discussed this before, but it looks like it was lost. Two issues:
Thumbnail Display Options
The goal here would be to allow people to more directly style the thumbnail. For instance:
The best way to do this may be with a CSS shadow part. TBD.
The text was updated successfully, but these errors were encountered: