Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target to the donation form #6

Closed
brettflorio opened this issue Sep 18, 2020 · 2 comments
Closed

Add target to the donation form #6

brettflorio opened this issue Sep 18, 2020 · 2 comments
Assignees
@ndvo
Labels
enhancement New feature or request

Comments

@brettflorio
Copy link
Contributor

Some systems (like Wix; really just Wix) only allow custom HTML to be embedded in iframes, which results in the donation form loading the Foxy checkout within the same iframe.

We need to allow the donation form to target the _parent or _top, to allow it to work in Wix.
@brettflorio brettflorio added the enhancement New feature or request label Sep 18, 2020
ndvo added a commit that referenced this issue Sep 18, 2020
@ndvo
feat(donation): additional cart parameters
207327a 
Fixes #3, #6
@brettflorio
Copy link
Contributor Author

@ndvo I think this was closed in #7, but it's not documented? Let's get this added to the Storybook documentation, yeah?

@ndvo
Copy link
Contributor

ndvo commented Sep 21, 2020

Ok. Right now it is set by default to _top. I'll add it to the docs.

ndvo added a commit that referenced this issue Sep 21, 2020
@ndvo
docs(donation): the target attribute defaults to _top and is provided…
13d5b3e 
… to the form element

improves solution to issue #6
ndvo added a commit that referenced this issue Sep 21, 2020
@ndvo
docs(donation): target attribute is passed to inner form and defaults…
f7a23e9 
… to _top

complements issue #6
@brettflorio brettflorio mentioned this issue Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndvo ndvo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettflorio @ndvo