Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jQuery deprecated live() with on() #50

Closed
rijarobinson opened this issue Aug 18, 2020 · 3 comments
Closed

Replace jQuery deprecated live() with on() #50

rijarobinson opened this issue Aug 18, 2020 · 3 comments
Assignees
@ndvo @rijarobinson

Comments

@rijarobinson
Copy link
Contributor

Live() is deprecated as of jQuery 1.9 and FoxyShop uses 1.11. Error for live() is causing Orders to malfunction.

Example of problematic code in orders.php:
$("#foxyshop_searchform button").live("click", function() {

Change this to:
$("#foxyshop_searchform").on("click", " button", function() {

Look for other instances to replace.
@FoxyCart FoxyCart deleted a comment from rijarobinson Aug 19, 2020
@adamjudd adamjudd mentioned this issue Aug 19, 2020
Merged
@rijarobinson
Copy link
Contributor Author

rijarobinson commented Aug 19, 2020 •
edited
Loading

Internal Foxy note: Notify to tickets linked to this issue.

@ndvo ndvo pinned this issue Aug 20, 2020
@ndvo ndvo unpinned this issue Aug 20, 2020
@ndvo
Copy link
Contributor

ndvo commented Aug 20, 2020

I'm on it

ndvo added a commit that referenced this issue Aug 20, 2020
@ndvo
fix #50
87f8261
@ndvo
Copy link
Contributor

ndvo commented Sep 11, 2020

Merge pull request #49 from FoxyCart/wp-5.5 closes this issue
c46a019

@ndvo ndvo closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndvo ndvo

@rijarobinson rijarobinson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndvo @rijarobinson