Wp 5.5 #49
Merged
Wp 5.5 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ndvo
commented
Aug 12, 2020
ndvo
commented
- Update Tested up to version 5.5
- Fix minor issues
- Add Brazilian Portuguese translation
Quantity text input fields with no predetermined range for quantity would not show the inputed text. By diminishing the padding value only for the hipothesis of an input text field (name ending with ||open) we make sure the user will be able to see the quantity in the field.
Order Desk is a proper name
|
Do we need to change: In the meantime, I need to install locally so I can test the changes. |
|
We'll need to get #50 fixed as part of this too - as that does appear to relate to the jump to 5.5 |
adamjudd
reviewed
Aug 19, 2020
Method live is deprecated as of jQuery 1.9
Should not rely on ||open existing at the name attribute.
|
Looking great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.