Update indexes after deleting lines #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function clean_indexes should be called to trigger a re-indexing according to byroot/pysrt#57 .
Move original SRT file to the temp dir if changes were made instead of renaming it in the source dir.
|
I see. Very useful, thank you. |
|
Let me know when you think this is ready to be merged |
|
Any update on this? |
|
Sorry for the delay. I found another bug, Will update this soon with the fix for that as well. |
|
No problem, |
SalSuleman
reviewed
Mar 19, 2021
| @@ -82,6 +84,7 @@ if __name__ == '__main__': | |||
| print("Removing: "+str(line)+"\n") | |||
| del subs[i] | |||
| modified = True | |||
| if modified: | |||
| move(filename, filename+'.bak') | |||
| if modified | |||
There was a problem hiding this comment.
Suggested change
| if modified | |
| if modified: |
| move(filename, filename+'.bak') | ||
| if modified | ||
| subs.clean_indexes() | ||
| move(filename, path.join(tempfile.gettempdir(), filename+'.bak'))1 |
There was a problem hiding this comment.
Suggested change
| move(filename, path.join(tempfile.gettempdir(), filename+'.bak'))1 | |
| move(filename, path.join(tempfile.gettempdir(), filename+'.bak')) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function clean_indexes should be called to trigger a re-indexing according to byroot/pysrt#57 .