Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 22.04 OEM-C kernel update breaks brightness keys #20

Closed
graue opened this issue Jan 17, 2024 · 2 comments
Closed

Ubuntu 22.04 OEM-C kernel update breaks brightness keys #20

graue opened this issue Jan 17, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@graue
Copy link

graue commented Jan 17, 2024

Hello,

On a 13th-gen Intel Framework laptop running Ubuntu 22.04, the brightness keys do not work unless the GRUB_CMDLINE_LINUX_DEFAULT variable in /etc/default/grub contains the parameter module_blacklist=hid_sensor_hub.

Therefore, step 2 of Framework's setup instructions includes a command that adds that parameter to that file (and runs sudo update-grub).

However, the suggested commands to run to upgrade the OEM-C kernel overwrite that value, causing the brightness keys to stop working. This caused a lot of confusion for me and substantial back-and-forth with your support team before finding the issue.

I recommend modifying the commands given in 22.04-OEM-C.md so that they don't overwrite that value and break the brightness key functionality.

@ctsdownloads
Copy link
Collaborator

@graue Ah, good catch! Yes, the code needs to be updated as not to beat up the existing parameters. I will put this into the queue for next week.

@ctsdownloads ctsdownloads self-assigned this Feb 16, 2024
@ctsdownloads ctsdownloads added the bug Something isn't working label Feb 16, 2024
@ctsdownloads
Copy link
Collaborator

ctsdownloads commented Feb 16, 2024

latest_oem_kernel=$(ls /boot/vmlinuz-* | awk -F"-" '{split($0, a, "-"); version=a[3]; if (version>max) {max=version; kernel=a[2] "-" a[3] "-" a[4]}} END{print kernel}') && sudo sed -i.bak '/^GRUB_DEFAULT=/c\GRUB_DEFAULT="Advanced options for Ubuntu>Ubuntu, with Linux '"$latest_oem_kernel"'"' /etc/default/grub && sudo update-grub

This new script totally omits the step that explicitly sets GRUB_CMDLINE_LINUX_DEFAULT to quiet splash.

This step is removed: sudo sed -i 's/^GRUB_CMDLINE_LINUX_DEFAULT.*/GRUB_CMDLINE_LINUX_DEFAULT="quiet splash"/g' /etc/default/grub

ctsdownloads added a commit that referenced this issue Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants