Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang-Formatter definition for the current formatting #578

Open
Framstag opened this issue Mar 16, 2018 · 3 comments
Open

Clang-Formatter definition for the current formatting #578

Framstag opened this issue Mar 16, 2018 · 3 comments
Assignees
@Framstag
Labels
feature For issues and pull request that request or implement a new feature help wanted Signal that help of other is appreciated infrastructure For infrastructure issues

Comments

@Framstag
Copy link
Owner

We should create a clang-formatter definition for the current code formatting (excluding Qt based parts). This seams to be support by a number of tools now and should ease the creation of correctly formatted patches.
@Framstag Framstag added feature For issues and pull request that request or implement a new feature help wanted Signal that help of other is appreciated infrastructure For infrastructure issues labels Mar 16, 2018
@Framstag Framstag self-assigned this Mar 17, 2018
@Framstag
Copy link
Owner Author

I have started to create such file, but the formatting result were not good. Problems:

  • Spacing around operators and assignments
  • Argument wrap around
  • Alignment of "*" and "&"
  • Spaces after "," in parameter list

@Framstag
Copy link
Owner Author

If someone is interested in the current result or wants to continue working on it, contact me.

@Framstag
Copy link
Owner Author

Now testing https://github.com/uncrustify/uncrustify, which is much more promissing.

Framstag pushed a commit that referenced this issue Mar 28, 2018
Issue #578: Added uncrustify configuration file. Uncrustify is a complex
51855ef 
source code formatter for C-like languages. The configuration sadly doesi
not yet match the libosmsocut formatting rules in ever details. There are
small differences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Framstag Framstag

Labels
feature For issues and pull request that request or implement a new feature help wanted Signal that help of other is appreciated infrastructure For infrastructure issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Framstag