just print warning when multipolyton ring has wrong type #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multipolygon contains more than one level of nested rings, second nested rigns should be outer. But is not so big problem when even these rings are with inner type (two nested inner rings). So, instead of skipping such rings with invalid type, just log warning and continue. When ring is skipped, ring grouping fail and whole multipolygon is omitted from import. It is too strict.
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multipolygon contains more than one level of nested rings, second nested rigns should be outer. But is not so big problem when even these rings are with inner type (two nested inner rings). So, instead of skipping such rings with invalid type, just log warning and continue.
When ring is skipped, ring grouping fail and whole multipolygon is omitted from import. It is too strict.
Fixing #1508