Check if lookupDir exists before iterating

[syyyr]

std::filesystem::recursive_directory_iterator throws if the directory doesn't exist.

[Framstag]

@syyyr : Can you fix the code in regard to @Karry comments?

[syyyr]

By the way, are you okay with me just sending fixes like these? It seemed to me like a quick and easy fix and for those, I tend to make PRs straight away without first making an issue with an exact explanation of the problem (and a reproducer). I wouldn't want to spam the repo with fixes that can't be reproduced by anyone else, so feel free to tell me if I should change my approach in any way. Thanks.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Framstag]

By the way, are you okay with me just sending fixes like these? It seemed to me like a quick and easy fix and for those, I tend to make PRs straight away without first making an issue with an exact explanation of the problem (and a reproducer). I wouldn't want to spam the repo with fixes that can't be reproduced by anyone else, so feel free to tell me if I should change my approach in any way. Thanks.

Libosmscout is a library for its users. As such I definitely accept such patches, if they improve the overall codebase and its stability or resilliance. Or add features that make sense in the code base.
I'm more. Strict if it comes to portability, dependencies or similar high impact stuff

[Karry]

LGTM, thank you!

[Karry]

By the way, are you okay with me just sending fixes like these? It seemed to me like a quick and easy fix and for those, I tend to make PRs straight away without first making an issue with an exact explanation of the problem (and a reproducer). I wouldn't want to spam the repo with fixes that can't be reproduced by anyone else, so feel free to tell me if I should change my approach in any way. Thanks.

I am more than happy with such merge requests ;-) I am creating issues just in case when I have no time for fix it right away. When it is simple like this one, there is no reason to waste time with describing problem in issue. Just my opinion.

[github-actions]

🎉 This issue has been resolved in v2024.06.02.1 (Release Notes)