locale-aware byte size formatter #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karry
force-pushed
the
locale-aware-byte-size-formatter
branch
from
4edfa6f
to
fdbc474
Compare
Karry
force-pushed
the
locale-aware-byte-size-formatter
branch
from
fdbc474
to
04d2f52
Compare
Char-based number formatting (using std::stringstream) is broken for locales with non-ascii thousand separator (at least with gcc 8.3.0), for that reason, we should provide custom locale aware number-to-string conversion for float numbers and use it in ByteSizeToString utility.
Karry
force-pushed
the
locale-aware-byte-size-formatter
branch
from
04d2f52
to
ddd5c98
Compare
Karry
force-pushed
the
locale-aware-byte-size-formatter
branch
from
36a6abb
to
e78e0d9
Compare
Karry
force-pushed
the
locale-aware-byte-size-formatter
branch
from
3919156
to
2e8f79b
Compare
|
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Char-based number formatting (using std::stringstream) is broken for locales with non-ascii thousand separator (at least with gcc 8.3.0), for that reason, we should provide custom locale aware number-to-string conversion for float numbers and use it in ByteSizeToString utility.