Read write lock fully reentrant #1562
Conversation
janbar
commented
Feb 13, 2024
janbar
commented
- It is fully re-entrant: read/write/read , and so it allows upgrading of reader to writer
- No more collisions when testing recursive S
- At least 5% faster than previous
Hehe, using std::list you will get 5 times slower. You are right, std::list use a chain internally, but we haven't access directly to the linked nodes, previous or next: We have to use the iterator. Also it allocates a new pointer for each added element, unless we implement a dedicated allocator ... much work for a so simple thing, and not really efficient. |
janbar
force-pushed
the
read_write_lock_reentrant
branch
from
0fa034d
to
6601810
Compare
|
Please wait before merge it. I am running some tests. Edit: using not tiled rendering, a reader thread still owns the lock in move. This behavior also existed before this commit, so there is no regression. |
- It is fully re-entrant: read/write/read - No more collisions when testing recursive S - At least 5% faster than previous - Uses TTAS for spin lock, instead TAS
janbar
force-pushed
the
read_write_lock_reentrant
branch
from
6601810
to
804a1e6
Compare
|
I updated the spin lock to implement TTAS instead TAS. The performance is better again, and I cannot do better. @Framstag , you can merge the PR as you wish. |
|
🎉 This issue has been resolved in |
