Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Replace pickle by json. Fixes security flaw #25. #36

Merged
merged 1 commit into from May 17, 2013

Conversation

Rogdham
Copy link
Contributor

@Rogdham Rogdham commented May 17, 2013

Breaks compatibility with prior versions.

As you mentioned in #25, json returns unicode object, so I just transform them back to str when using .load.
There is no need to do a similar thing for .dumps since it defaults to encoding with utf-8.

Breaks compatibility with prior versions.
@FredKSchott FredKSchott merged commit 2189404 into FredKSchott:master May 17, 2013
@FredKSchott
Copy link
Owner

Great fix, thanks! Would love more info on the security flaw in question, but maybe in a week or two when most have upgraded to a newer version

@Rogdham Rogdham deleted the pickle-security-flaw branch May 17, 2013 21:56
@Rogdham
Copy link
Contributor Author

Rogdham commented May 17, 2013

Sure, I've almost finished writing a blog post about that, but as you said I will wait some time before releasing it ;-)

I will try to remember pinging you when I publish it.

@Rogdham
Copy link
Contributor Author

Rogdham commented May 27, 2013

@FredKSchott: I've just published the exploit: http://r.rogdham.net/21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants