add svelte to packageImportFields (#1501)

FredKSchott · Nov 5, 2020 · e3eca61 · e3eca61 · vercel · Nov 5, 2020
1 parent 282ccf3
commit e3eca61
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/plugins/plugin-svelte/plugin.js b/plugins/plugin-svelte/plugin.js
@@ -18,6 +18,8 @@ module.exports = function plugin(snowpackConfig, pluginOptions = {}) {
   snowpackConfig.installOptions.rollup.plugins.push(
     svelteRollupPlugin({include: '**/node_modules/**', dev: isDev}),
   );
+  // Support importing sharable Svelte components.
+  snowpackConfig.installOptions.packageLookupFields.push('svelte');
 
   if (
     pluginOptions.generate !== undefined ||

diff --git a/plugins/plugin-svelte/test/plugin.test.js b/plugins/plugin-svelte/test/plugin.test.js
@@ -6,10 +6,19 @@ jest.mock('svelte/compiler', () => ({compile: mockCompiler, preprocess: mockPrep
 
 const plugin = require('../plugin');
 
-const mockConfig = {buildOptions: {sourceMaps: false}, installOptions: {rollup: {plugins: []}}};
+let mockConfig;
 const mockComponent = path.join(__dirname, 'Button.svelte');
 
 describe('@snowpack/plugin-svelte (mocked)', () => {
+  beforeEach(()=>{
+    mockConfig = {
+      buildOptions: {sourceMaps: false},
+      installOptions: {
+        rollup: {plugins: []},
+        packageLookupFields: [],
+      },
+    };
+  })
   afterEach(() => {
     mockCompiler.mockClear();
     mockPreprocessor.mockClear();
@@ -128,4 +137,11 @@ describe('@snowpack/plugin-svelte (mocked)', () => {
       ]
     `);
   });
+  it('supports importing svelte components', async () => {
+    plugin(mockConfig,{});
+    expect(mockConfig.installOptions.packageLookupFields).toEqual(['svelte']);
+    mockConfig.installOptions.packageLookupFields = ['module'];
+    plugin(mockConfig,{});
+    expect(mockConfig.installOptions.packageLookupFields).toEqual(['module', 'svelte']);
+  });
 });