Add svelte to packageLookupFields #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/dwc7qnds5 |
firefish5000
force-pushed
the
svelte-packageFields
branch
from
2dd6689
to
1d026be
Compare
firefish5000
force-pushed
the
svelte-packageFields
branch
from
1d026be
to
4176414
Compare
firefish5000
changed the title
firefish5000
force-pushed
the
svelte-packageFields
branch
from
4176414
to
2d56fbd
Compare
firefish5000
force-pushed
the
svelte-packageFields
branch
from
2d56fbd
to
0fc67b4
Compare
|
That took a few more tries than it should have. Finally figured out how to get jest running locally (didn't realize I needed to build first) |
|
LGTM! Thanks for the change 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Makes plugin-svelte append 'svelte' to snowpack's
packageLookupFields.Used for importing svelte sharable components into svelte apps.
Testing
Add test to ensure
packageLookupFieldsfield changed as expected.Docs
No docs added. I believe it would belong in lower level docs than any existing documentation.