Warnings when running polymer build using pika-web produced web_modules

[krumware]

Carried over from polymer/pwa-starter-kit: Polymer/pwa-starter-kit#339
Relevant branch for viewing package.json versions: https://github.com/krumIO/pwa-starter-kit/tree/template-pika-web

Steps to reproduce:

1. Clone the repo/branch git clone -b template-pika-web https://github.com/krumIO/pwa-starter-kit.git
2. run npm install
3. run + observe npm run build

When running npm run build we do see some warning flags thrown, but looking at these in action may provide good feedback for both Lit and Pika:

C:\scrubbed\pwa-starter-kit [pika-web +0 ~1 -0 !]> npm run build

> pwa-starter-kit@0.9.0 build scrubbed\pwa-starter-kit
> polymer build --auto-base-path && gulp prpl-server

info:   Clearing build\ directory...


    window.customElements.define(tagName, clazz);
                                 ~~~~~~~

file:///scrubbed/pwa-starter-kit/web_modules/lit-element.js(1985,34) warning [cant-determine-element-tagname] - Unable to evaluate this expression down to a definitive string tagname.


            window.customElements.define(tagName, clazz);
                                         ~~~~~~~

file:///scrubbed/pwa-starter-kit/web_modules/lit-element.js(2001,42) warning [cant-determine-element-tagname] - Unable to evaluate this expression down to a definitive string tagname.


const connect = (store) => (baseElement) => class extends baseElement {
                                                          ~~~~~~~~~~~

file:///scrubbed/pwa-starter-kit/web_modules/pwa-helpers.js(25,59) warning [could-not-resolve-reference] - Could not resolve reference to class
info:   (esm-bundled) Building...
info:   (es6-bundled) Building...
info:   (es5-bundled) Building...
info:   (es5-bundled) Build complete!
info:   (esm-bundled) Build complete!
info:   (es6-bundled) Build complete!
[17:56:32] Using gulpfile C:\scrubbed\pwa-starter-kit\gulpfile.js
[17:56:32] Starting 'prpl-server'...
[17:56:32] Starting 'prpl-server:clean'...
[17:56:32] Finished 'prpl-server:clean' after 27 ms
[17:56:32] Starting 'prpl-server:build'...
[17:56:33] Finished 'prpl-server:build' after 307 ms
[17:56:33] Finished 'prpl-server' after 340 ms
C:\scrubbed\pwa-starter-kit [pika-web +0 ~1 -0 !]> npm run serve

> pwa-starter-kit@0.9.0 serve C:\scrubbed\pwa-starter-kit
> prpl-server --root server/build

Loading config from "server\build\polymer.json".
Serving files from "C:\scrubbed\pwa-starter-kit\server\build".
Detected push manifest "esm-bundled\push-manifest.json".
Detected push manifest "es6-bundled\push-manifest.json".
Detected push manifest "es5-bundled\push-manifest.json".
Registered entrypoint "esm-bundled/index.html" with capabilities [es2015,modules].
Registered entrypoint "es6-bundled/index.html" with capabilities [es2015].
Registered entrypoint "es5-bundled/index.html" with capabilities [].

prpl-server listening
http://127.0.0.1:8080

[krumware]

@FredKSchott as requested

[FredKSchott]

Oooh i see what’s going on now. I had thought that these warnings were coming from @pika/web install, but they’re really coming from ‘polymer build’ not understanding the @pika/web install. Let me see if there’s anything I can do on my end to resolve this

…

On Fri, Mar 8, 2019 at 7:31 AM Colin Griffin ***@***.***> wrote: @FredKSchott <https://github.com/FredKSchott> as requested — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAl-k3WCSDtawoX15pC4r9KB8yEVrBtDks5vUoJdgaJpZM4blkxa> .

[FredKSchott]

Yea I can't figure it out, sorry. For some reason it fails when it analyzes this bundled file, yet doesn't seem to mind when it's unbundled in node_modules. /cc @usergenic in case the Polymer team has the time to debug further.

@krumware In that case, I'd be curious if you even need polymer-build & prpl-server. If all of your web_modules/ dependencies run natively in the browser, you can just serve your app with a simple static app server? A big part of @pika/web is to show the world that you don't need a bundler. If the Polymer team never plans to merge this, then I'd recommend just dropping them and replacing them with something simple like https://www.npmjs.com/package/serve.

[FredKSchott]

Closing this since I think even best case scenario there's nothing else for us to do here. But happy to keep the discussion going