-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings when running polymer build using pika-web produced web_modules #22
Comments
@FredKSchott as requested |
Oooh i see what’s going on now. I had thought that these warnings were
coming from @pika/web install, but they’re really coming from ‘polymer
build’ not understanding the @pika/web install. Let me see if there’s
anything I can do on my end to resolve this
…On Fri, Mar 8, 2019 at 7:31 AM Colin Griffin ***@***.***> wrote:
@FredKSchott <https://github.com/FredKSchott> as requested
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAl-k3WCSDtawoX15pC4r9KB8yEVrBtDks5vUoJdgaJpZM4blkxa>
.
|
Yea I can't figure it out, sorry. For some reason it fails when it analyzes this bundled file, yet doesn't seem to mind when it's unbundled in node_modules. /cc @usergenic in case the Polymer team has the time to debug further. @krumware In that case, I'd be curious if you even need |
Closing this since I think even best case scenario there's nothing else for us to do here. But happy to keep the discussion going |
Carried over from polymer/pwa-starter-kit: Polymer/pwa-starter-kit#339
Relevant branch for viewing package.json versions: https://github.com/krumIO/pwa-starter-kit/tree/template-pika-web
Steps to reproduce:
git clone -b template-pika-web https://github.com/krumIO/pwa-starter-kit.git
npm install
npm run build
When running
npm run build
we do see some warning flags thrown, but looking at these in action may provide good feedback for both Lit and Pika:The text was updated successfully, but these errors were encountered: