-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] local install source import scanner speed regression in v3.3.0 #3188
Comments
Thank you for posting this, you've just saved me a lot of pain! My observation from the output is it appears the dependencies are being upgraded numerous times on 3.3.0, since the whole block is printed many times, whereas dropping back to 3.2.2 the block slowly gets printed out and the application starts. |
Experiencing the same in prompt hangs on this view forever (+15mins, I did not have the time to wait until completion, might try tonight testers are needed). As @fgblomqvist versions < 3.3.0 do not seem impacted. |
To pinpoint this further, I'd expect the regression to be in the The repeating logs that @Nick-Lucas mentioned might be due to the caching (that was implemented to fix the first regression) not working as it should perhaps? |
this still occurs on 3.3.7, any idea what might cause this ? |
I don't know if anyone but @FredKSchott understands the intricacies of |
Is there any better way to speed up big component import dev server init speed ? Such as |
It works if i remove nivo from my project's dependencies :( |
@fgblomqvist could it make sense to use the boolean value here: https://github.com/snowpackjs/snowpack/blob/b375b8a3d6e0448a29ae2aa56b75a43ac2118d58/snowpack/src/sources/local.ts#L507 As I understand it, and I might be very wrong, this would stop building the package again, but the package should still be in the cache? |
Could certainly be something like that, but not sure exactly how to take advantage of it 😕. My motivation to put a lot of time into this dropped since I ran into several other issues and overall I felt like the development was a bit "unstable" (too many regressions). I don't blame anyone and I still have faith that this will be a great project one day though. |
this fix is related to FredKSchott#3188
Bug Report Quick Checklist
Describe the bug
Back in v3.1, the import scanner for local installs had regressed from v3.0, but thankfully that regression was fixed:
#2900
Unfortunately, it seems like it has regressed again in v3.3.0. In the example repo described below, the "start-to-ready" time for
snowpack dev
has gone from ~45 seconds in v3.2.2 to ~6.5 minutes in v3.3.0. That's almost 9x slower 😢 . And this is on a fast machine. On my laptop, it looks like it would take 30-60 minutes (haven't let it finish so far), or maybe longer.To Reproduce
We can't fix bugs that we can't see for ourselves. Issues often need to be closed if this section is skipped.
npx create-snowpack-app new-dir --template @snowpack/app-template-react-typescript
cd new-dir
npm install antd @ant-design/icons
import * as x from 'antd';
andimport * as y from '@ant-design/icons';
tosrc/App.tsx
npm start
, and watch it take forever until it finishes.Expected behavior
It should be fast 😄.
Anything else?
I'm suspecting this PR might be the culprit:
#3028
Logs for v3.2.2 (fast) run
Logs for v3.3.0 (slow) run
I also posted a discussion here: #3152
But that was before I did the actual testing with some sample repos.
The text was updated successfully, but these errors were encountered: