improve import scanner perf #2900
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/H1UaXRGzDTLcKjhHBU2ouUeDci3T |
| @@ -239,6 +242,17 @@ export default { | |||
| depth = 0, | |||
| ) { | |||
| config = config || _config; | |||
| // Imports in the same project should never change once resolved. Check the momized cache here to speed up faster repeat page loads. | |||
There was a problem hiding this comment.
Just because I can: "momized" -> "memoized" 😄
|
Are those stats the time per import? |
|
That's for just the antd import, although that's a pretty special edge case. The bottleneck was on the "per import within the package" processing time, and antd has something like 50 different import statements to other sub-packages within it. It's a big package... |
|
Hi @FredKSchott , I was being impatient here to try out new version.. pls ignore this comment it builds properly... |
Changes
Two big changes here to help the perf issues reported here: #2896 (reply in thread)
antdfirst load down from ~700ms to ~300msantdsecond load down from ~300ms to ~80ms.@ant-design/icons-svgto the "never peer" list so that they get automatically bundled into any packages that request them. They're so small that this shouldn't seriously impact dev performance.Testing
Docs