feat: replace %SNOWPACK_PUBLIC_*% and %MODE% environment variables in HTML
#900
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/9nudk1pya |
There was a problem hiding this comment.
Looking good!
Can we add/clarify the docs at https://www.snowpack.dev/#environment-variables in this PR as well?
| @@ -197,7 +197,7 @@ export async function buildFile( | |||
| ): Promise<SnowpackBuildMap> { | |||
| // Pass 1: Find the first plugin to load this file, and return the result | |||
| const loadResult = await runPipelineLoadStep(srcPath, buildFileOptions); | |||
| // Pass 2: Pass that result through every plugin transfomr() method. | |||
| // Pass 2: Pass that result through every plugin transform() method. | |||
ping @FredKSchott does that sound good?
| hmr: false, | ||
| config: this.config, | ||
| mode: 'production', | ||
| }); |
There was a problem hiding this comment.
I had to add the mode option to differentiate between the build & dev commands
| return `export default ${JSON.stringify(envObject)};`; | ||
| } | ||
|
|
||
| const PUBLIC_ENV_REGEX = /^SNOWPACK_PUBLIC_/; |
There was a problem hiding this comment.
Should it be /^SNOWPACK_PUBLIC_.*/ so it doesn't match a SNOWPACK_PUBLIC_ variable?
There was a problem hiding this comment.
yea, good catch. I think that that's worth adding. technically it should be /^SNOWPACK_PUBLIC_.+/, since * can match 0 items.
There was a problem hiding this comment.
Indeed, /^SNOWPACK_PUBLIC_.+/ is what I meant 😉
There was a problem hiding this comment.
I'll make I made a follow up issue so we can ship this change: #924
gr2m
changed the title
%SNOWPACK_PUBLIC_*% and %MODE% environment variables in HTML
fixes #898 /cc @silverwind @FredKSchott
Changes
Testing
test/build/