-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore SNOWPACK_PUBLIC_
env variable when generating __snowpack__/env.js
#924
fix: ignore SNOWPACK_PUBLIC_
env variable when generating __snowpack__/env.js
#924
Conversation
…Y_ENV_VAR to make clear it is a user-defined env variable
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/4ale66yvb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think the error on the Windows builds is legit. I tried to restart the build but it persists:
The https://github.com/pikapkg/snowpack/pull/924/checks?check_run_id=1033570802#step:4:133
I wonder if the "'be' is not recognized as an internal or external command" comes from the |
ha! that's fascinating. I don't know enough about cross-env, but i'd say just change it to 'ignoreme' or 'tobeignored' and call it a day :) |
Still LGTM, feel free to merge whenever you get tests passing :) |
Follow up to https://github.com/pikapkg/snowpack/pull/900\#discussion_r477058829 /cc @silverwind @FredKSchott