Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grunt task to embed images was added in 6e58773 when ungit had a lot more images (which were referenced from CSS).
Now, the task only embeds the fonts used by ungit, which is actually counter-productive:
The font declaration includes the
local()
-function so that fonts don't need to be loaded if they are already installed, but this optimization is redundant as the font is embedded in the same file.ungit/public/less/generic.less
Lines 12 to 24 in 09232a7
Bootstrap includes multiple file types of the glyphicon font so the browser can pick their best supported one. By embedding the fonts, all alternatives are served.
ungit/public/vendor/less/bootstrap/glyphicons.less
Lines 10 to 17 in 09232a7
File size comparisons (Firefox network panel):