Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt translation files are out-of-date #149

Closed
kaktusus opened this issue May 13, 2022 · 24 comments
Closed

Qt translation files are out-of-date #149

kaktusus opened this issue May 13, 2022 · 24 comments
Assignees

Comments

@kaktusus
Copy link
Contributor

kaktusus commented May 13, 2022

needs urgent attention

Thanks to the support of @Kuzma30 we managed to validate the problem of the lack of translations in Polish for the windows function buttons.

FreeCAD/FreeCAD#6875

Ultimately, the problem lies in the outdated content of the QT translation files relative to the source project.
Related to the file qt_pl.qm https://github.com/qt/qttranslations/blob/dev/translations/qt_pl.ts
The file qt_pl.qm depends on the qtbase_pl multimedia_pl files also from the QT project.

Please update the QT environment files for the Polish language in the FreeCAD project.

@kaktusus
Copy link
Contributor Author

Source files with translations for QT environment:
https://github.com/FreeCAD/FreeCAD/tree/master/src/Gui/Language

@luzpaz
Copy link
Collaborator

luzpaz commented May 13, 2022

So you're saying the version schema needs to be updated?

@kaktusus
Copy link
Contributor Author

I want to update the files to contain all the translated records,

By the way, I discovered as you did that the structure has changed.

I think it would be a good idea to update the whole thing for the other languages as well (all languages, not just selected ones)

I can also prepare a PR for the "old" qt_pl file with the completed translations, but this will not ensure compatibility with the current QT project.

Which solution is better?

@Kuzma30
Copy link

Kuzma30 commented May 13, 2022

I have idea. May be we delete this Qt translation from FreeCAD source. This is Qt related package. I think there is ability for all OS get it in actual state.
For Linux this files provides as separate package. For example for Ubuntu this is https://packages.ubuntu.com/bionic/qttranslations5-l10n.
For Windows we can transfer it to LibPack. For Mac - I don't know (I don't work with Mac at all)

@luzpaz
Copy link
Collaborator

luzpaz commented May 13, 2022

Lets open a forum thread to discuss this.

@Kuzma30
Copy link

Kuzma30 commented May 13, 2022

Agree with you. Please create forum thread.

@kaktusus
Copy link
Contributor Author

I have idea. May be we delete this Qt translation from FreeCAD source. This is Qt related package. I think there is ability for all OS get it in actual state.

Very but very good solution.

Always ensures compatibility and up-to-date.

@kaktusus
Copy link
Contributor Author

Agree with you. Please create forum thread.

In the sub forum for translators, of course.

;-p

@kaktusus
Copy link
Contributor Author

kaktusus commented May 13, 2022

image

In my opinion, Alex's (Kuzma30) proposal is a good one, it brings a positive breath of fresh air and relieves the responsibility of taking care of the QT environment files. The lack of their updates caused a big problem with the Polish language interface. This may happen many times.
I think, that the developers project managers should make a decision in this topic.

@luzpaz
Copy link
Collaborator

luzpaz commented May 13, 2022

This is not just for polish language but all languages, right?

@kaktusus
Copy link
Contributor Author

kaktusus commented May 14, 2022

Yes, a problem in the Polish language has led us to this point.
The issue has become global. You can do something good for the whole project.

@kaktusus
Copy link
Contributor Author

Additionally please note that the FreeCAD repository on GitHub is not consistent, it contains old files:

  1. qt_xx.qm for 11 languages

image

In case of Polish language, this source is not up-to-date - it does not contain translations for the program options used.

  1. qtbase_xx.qm for 10 languages

image

Currently (2022-05-14) FreeCAD is translated into 66 languages.

@kaktusus
Copy link
Contributor Author

Noticed that this topic is developed by @wmayer and managed by @yorikvanhavre

@kaktusus
Copy link
Contributor Author

Solving the lack of Polish translations: #6882

@kaktusus
Copy link
Contributor Author

kaktusus commented May 14, 2022

A different global solution might be to give up additional "foreign" translation files.
FreeCAD has its own personal files used for GUI localization.
As you can see the use of translations from foreign files (QT) is small, in addition similar strings are already present in FreeCAD translation engine..

I think it's worth considering which solution to use and what advantages and disadvantages does it bring.

@kaktusus
Copy link
Contributor Author

OS: Debian GNU/Linux bookworm/sid (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.28884 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 51fdb42)
Hash: 51fdb42f21b4c6a7c9f91956e51427b896070f96
Python 3.9.12, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: Polish/Poland (pl_PL)
Installed mods: 
...

So the problem with untranslated function key labels in the Polish GUI has been solved.
Fix FreeCAD/FreeCAD#6883

I wonder who else will struggle with it.

The topic for now I do not close because there were raised here interesting matters.

@kaktusus
Copy link
Contributor Author

kaktusus commented Jun 5, 2022

Foreign translation files have once again left a bad mark.

obraz

Menu contains incorrectly translated keyboard shortcut.
Repairing this will be cumbersome but possible.

@Kuzma30
Copy link

Kuzma30 commented Jun 6, 2022

You can check translation for this text in qt related .qm file.

@adrianinsaval
Copy link
Member

IMO it doesn't make sense to have Qt translations on our source code

@chennes
Copy link
Member

chennes commented Apr 23, 2023

Are there any actions left to be taken on this Issue?

@kaktusus
Copy link
Contributor Author

My problem was directly solved.
But in general the topic is open, it will also cause problems for translators of other nationalities.

@chennes chennes self-assigned this Apr 28, 2023
@chennes
Copy link
Member

chennes commented Apr 28, 2023

I am going to merge in the latest files from the Qt GitHub repo once we have a system for compiling the QM files from the TS files as part of the compilation process. Hopefully in the next couple of weeks here.

@chennes chennes changed the title [QT] Source files QT environment for Polish language Qt translation files are out-of-date Apr 28, 2023
@kaktusus
Copy link
Contributor Author

When I made the corrections to the Polish language I did it locally bypassing the source files in the QT repo.
So at that time the translation files in FreeCAD were more up-to-date than in the QT repository.

@chennes
Copy link
Member

chennes commented May 19, 2023

This merge is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants