fixes 0003341: Undoing is missing steps

FreeCAD · Oct 13, 2018 · 571f752 · 571f752
1 parent cb30a82
commit 571f752
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/src/Gui/propertyeditor/PropertyEditor.cpp b/src/Gui/propertyeditor/PropertyEditor.cpp
@@ -103,8 +103,15 @@ void PropertyEditor::closeEditor (QWidget * editor, QAbstractItemDelegate::EndEd
 {
     if (autoupdate) {
         App::Document* doc = App::GetApplication().getActiveDocument();
-        if (doc && doc->isTouched())
-            doc->recompute();
+        if (doc) {
+            if (doc->isTouched()) {
+                doc->commitTransaction();
+                doc->recompute();
+            }
+            else {
+                doc->abortTransaction();
+            }
+        }
     }
     QTreeView::closeEditor(editor, hint);
 }
@@ -140,6 +147,13 @@ void PropertyEditor::currentChanged ( const QModelIndex & current, const QModelI
 
 void PropertyEditor::onItemActivated ( const QModelIndex & index )
 {
+    if (autoupdate) {
+        PropertyItem* property = static_cast<PropertyItem*>(index.internalPointer());
+        QString edit = tr("Edit %1").arg(property->propertyName());
+        App::Document* doc = App::GetApplication().getActiveDocument();
+        if (doc)
+            doc->openTransaction(edit.toUtf8());
+    }
     openPersistentEditor(model()->buddy(index));
 }