Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Assembly workbench Distance joint not working #12490

Closed
2 tasks done
macdroid53 opened this issue Feb 18, 2024 · 15 comments · Fixed by #12406
Closed
2 tasks done

[Problem] Assembly workbench Distance joint not working #12490

macdroid53 opened this issue Feb 18, 2024 · 15 comments · Fixed by #12406
Labels
Bug This issue or PR is related to a bug Missing: example file Missing: tested on dev version WB Assembly Related to the Integrated Assembly Workbench

Comments

@macdroid53
Copy link

macdroid53 commented Feb 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

When attempting to set a zero distance joint between vertexes it fails to adjust the location.
Peek 2024-02-18 08-21

Full version info

OS: Manjaro Linux (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.36012 (Git)
Build type: None
Branch: main
Hash: 62c8469bded2f39099c7b067889052818b659fe9
Python 3.11.6, Qt 5.15.12, Coin 4.0.2, Vtk 9.3.0, OCC 7.7.2
Locale: English/United States (en_US)
Installed mods: 
  * Silk 0.1.5
  * Defeaturing 1.2.2
  * Curves 0.6.22
  * CurvedShapes 1.0.5
  * DynamicData 2.60.0
  * OpenDark 2023.12.17
  * lattice2 1.0.0
  * sheetmetal 0.4.0
  * Manipulator 1.5.7
  * kicadStepUpMod 10.22.9
  * QuickMeasure 2022.10.28
  * fasteners 0.5.0
  * Help 1.0.3
  * ProDarkThemePreferencePack 1.0.0
  * freecad.gears 1.0.0
  * ExtremeProDark 2.9.0

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@macdroid53
Copy link
Author

After some experimentation it appears it is because the Std_Part object added (because Insert as Part is ticked) to the to the Part Extrude the Placement is not handled correctly.
If the Part Extrude is is linked with "Insert as Part" unticked, joints work as expected.

@maxwxyz maxwxyz added Bug This issue or PR is related to a bug WB Assembly Related to the Integrated Assembly Workbench labels Feb 19, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Feb 19, 2024

@PaddleStroke also concerning the distance joint

@PaddleStroke
Copy link
Contributor

Can you please attach the files so I can test?
It seems the JCS is not positioning correctly.

@macdroid53
Copy link
Author

  • Create a new document
  • Create a Part WB solid (Sketch and Extrude)
  • Save
  • Create a new document.
  • Create a Part Design Body, Sketch, and Pad
  • Save
  • Create a new document
  • Create an Assembly
  • Save
  • Click Insert link
  • Tick "Insert as Part"
  • Insert the the Body and Extrude from above files
  • Attempt to add a Distance (or any) constraint

With source 36120, produces the same results as shown in movie earlier in this issue thread.

@macdroid53
Copy link
Author

@PaddleStroke also concerning the distance joint

I gave instructions above on how to test.

@macdroid53
Copy link
Author

Is this stalled?

@PaddleStroke
Copy link
Contributor

@macdroid53 do not worry I will fix it. I have just not come to it yet.

@PaddleStroke
Copy link
Contributor

PaddleStroke commented Mar 11, 2024

I cannot produce this error (in my current branch at least). JCS are positioning correctly.
image

First is that I killed the 'insert as part' option that made little sense. But even recreating the same as with insert as part (basically it created a part and put the link in the part) I cannot reproduce the problem.

Now I'm not sure if this bug is fixed in my branch or if I have not reproduced the exact same file.

Please make sure to attach the file when you report a bug so that it removes uncertainty regarding it's reproduction.

Any chance you can try to reproduce this bug in my dev branch?
Thanks

@macdroid53
Copy link
Author

I have no file that shows the issue. Once the file has been saved the behavior is different. I am happy to provide a file when it shows the issue...in this case there is none.

This image shows what I get after "Insert as part" is used and I attempt to make a constraint.

Note the vertex selected and the axis that is associated. This does not happen is the "Insert as part" is not used.

It does not happen if the file is closed and opened again (I just noticed this) (but, after reopening the file, attempting to create a constraint crashes FreeCAD.)

Screenshot_20240311_103140

I'm happy to build your branch, unfortunately, I know how to build main, I know how to build a PR...but, I don't know how to get your dev branch source to build. Sorry.

@PaddleStroke
Copy link
Contributor

PaddleStroke commented Mar 11, 2024

@macdroid53 great thanks, it's a PR actually : #12406

@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 11, 2024

#12406 currently does not fix distance of 2 vertices with offset 0.
Also lines do not work:
grafik

@PaddleStroke
Copy link
Contributor

@maxwxyz I have put a fix for distance 0 between 2 vertexes. Was there a stand alone issue for this problem?

PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Mar 14, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 14, 2024

@PaddleStroke this one here

@PaddleStroke
Copy link
Contributor

Ah right, I got confused because later @macdroid53 mentioned problem concerning all joints.
So anyway the initial problem of the issue is fixed. Distance of 0 between vertex is fixed.

@macdroid53
Copy link
Author

macdroid53 commented Mar 17, 2024

Ah right, I got confused because later @macdroid53 mentioned problem concerning all joints. So anyway the initial problem of the issue is fixed. Distance of 0 between vertex is fixed.

I mentioned that because it didn't appear to be the joints but the way the Part container was added to the solid it "Insert as part" was active and the user moved the cursor before click to drop the solid.

This effected all joint types when "Insert as part" was active.

PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Mar 18, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Mar 18, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Mar 18, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue Mar 19, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Mar 20, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Mar 21, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Mar 26, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 2, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 2, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 3, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 11, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 17, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 19, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 19, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 25, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 25, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 26, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 27, 2024
PaddleStroke added a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 30, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue Apr 30, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue May 1, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue May 1, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue May 2, 2024
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug Missing: example file Missing: tested on dev version WB Assembly Related to the Integrated Assembly Workbench
Projects
None yet
3 participants