Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Array elements and their number are not taken into account in BIM managers #12802

Closed
2 tasks done
kaiwas opened this issue Mar 7, 2024 · 7 comments · Fixed by #12899
Closed
2 tasks done
Assignees
Labels
WB Draft Related to the Draft Workbench

Comments

@kaiwas
Copy link

kaiwas commented Mar 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

If you multiply any element using an array (and this can happen in many tasks), then the number of these elements does not change in any way in BIM managers.
You can see this situation in the pictures.

I tried changing the array parameters and it didn't help at all.

Scr_20240307_162510
Scr_20240307_162749

I would also like there to be a grouping of elements with similar parameters. Seeing 4/10/30 columns (or something else) with the same parameters in the list is not very useful. We have to recalculate them manually. But to see that there are 4/10/30 such columns would be very convenient.

group

The situation is similar with the window and door manager.

Full version info

any version / any system

Subproject(s) affected?

Arch

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 7, 2024

@yorikvanhavre is this BIM related or a function from Arch? I have little experience with Arch/BIM.

@maxwxyz maxwxyz added the Missing: feedback If feedback is requested label Mar 8, 2024
@yorikvanhavre
Copy link
Member

Indeed you can create arrays with Draft tools. However, the BIM quantities manager only looks at BIM objects, and the Draft array is not considered a BIM object, therefore it is not seen by the BIM manager, who only sees the base object.

This is a valid issue.

Only I'm not sure how to solve this. One solution that is easy to implement by the user is to wrap the array object in a BIM component, thus turning it into a BIM object. We have to check if the quantities are correctly set in that case, though. Would you test that @kaiwas ?

Another possibility would be to consider the Draft array as a kind of "feature" of its underlying BIM object and automatically "expand" the base object, both in quantities and IFC export. There is a partial support for that in IFC export already. The problem here is that IFC does not support the concept of arrays, so arrays of objects are exported as a series of individual objects.

Maybe that's what we need to do here:

  • In the quantities manager, detect if an object is part of a Draft array
  • If yes, duplicate the entry the correct number of times
  • Verify if the array is exported to IFC as a series of individual objects
  • Verify if each individual object has its quantities set

@yorikvanhavre yorikvanhavre self-assigned this Mar 8, 2024
@yorikvanhavre yorikvanhavre removed the Missing: feedback If feedback is requested label Mar 8, 2024
@maxwxyz maxwxyz added the WB Draft Related to the Draft Workbench label Mar 8, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 8, 2024

Is it ok to leave the issue here or should it be in the BIM repo?

@kaiwas
Copy link
Author

kaiwas commented Mar 8, 2024

Only I'm not sure how to solve this. One solution that is easy to implement by the user is to wrap the array object in a BIM component, thus turning it into a BIM object. We have to check if the quantities are correctly set in that case, though. Would you test that @kaiwas ?

I'll try your recipe. But I admit that I don’t yet know how the IFS works with all its properties. I'm just looking for options for quick calculations, but BIM modeling itself is not familiar to me. But I'll try.

Another possible option would be to “destruct” the array. Those. Each element of the array would be transformed into a unique object when a button was pressed. Unfortunately, this method is not very flexible, because if you need to change the number of elements, you will have to re-create the array. And delete previously made “objects”.

I understand that taking into account massive numbers is not an easy task. Because the same “element” can be used in several different arrays or even be a separate object.
Here we clearly need to implement some additional logic. The first thing that comes to mind is that an object participating in arrays should not be automatically taken into account in quantities. But if you enable some kind of “checkbox”, it becomes visible for calculation.

@kaiwas
Copy link
Author

kaiwas commented Mar 8, 2024

I'm not a programmer and don't know the deep capabilities. But I will try to think about the very logic of this feature.
This is very relevant because the fastest way to arrange an object with a certain step is an array.
(indication of difficulties via the link. Please read)
#12500

If there was another faster way, then the array would not be needed so often. Just imagine how many actions you need to do without an array in order to arrange the elements of the rafter system in the picture
2024-03-08 15_14_23

@kaiwas
Copy link
Author

kaiwas commented Mar 10, 2024

I don’t quite understand what I’m doing, but I tried to assign IFS properties to the array. The array appeared in the list as a single element without additional parameters.
It seems it's not easy.
Scr_20240310_112533

@yorikvanhavre
Copy link
Member

Wtih 4133053 arrays are now correctly exported as an IfcElementAssembly, and contain a number of subelements. Next step is to verify the quantities.

yorikvanhavre added a commit to yorikvanhavre/BIM_Workbench that referenced this issue Mar 12, 2024
yorikvanhavre added a commit to yorikvanhavre/BIM_Workbench that referenced this issue Mar 12, 2024
@maxwxyz maxwxyz linked a pull request Mar 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants