Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Unit system with dimensions displayed in meters #7395

Open
2 tasks done
FEA-eng opened this issue Aug 25, 2022 · 11 comments
Open
2 tasks done

[Feature Request] Unit system with dimensions displayed in meters #7395

FEA-eng opened this issue Aug 25, 2022 · 11 comments
Labels
Feature FR for improvements or new features Units Issue related to units of measurement

Comments

@FEA-eng
Copy link
Contributor

FEA-eng commented Aug 25, 2022

Is there an existing request for this?

  • I have searched the existing requests

Forums discussion

https://forum.freecadweb.org/viewtopic.php?f=8&t=71365

Subproject(s) affected?

Core

Idea description

The currently available MKS (m/kg/s/degree) unit system doesn't always result in dimensions being displayed in meters - millimeters are still used for values bellow 0.1m
For some applications (e.g. civil engineering) it would be useful to have a unit system that actually changes the display of all dimensions to meters.

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz added Units Issue related to units of measurement Feature FR for improvements or new features labels Aug 25, 2022
@adrianinsaval
Copy link
Member

Looking at the code MKS is supposed to display values bellow 100mm in mm and values above that but bellow 10000000mm are displayed in m and so on for even higher or lower values

else if(UnitValue < 100.0) {
unitString = QString::fromLatin1("mm");
factor = 1.0;
}
else if(UnitValue < 10000000.0) {
unitString = QString::fromLatin1("m");
factor = 1000.0;
}

These are sane ranges IMO, if there is somewhere where mm are being used regardless of these rules I think that would be a bug but we would need examples of that.

@adrianinsaval
Copy link
Member

@FEA-eng respond please, where is there an issue where mm are displayed with MKS? if no example is given this issue should be closed IMO, or probably closed either way and instead make an issue for the field that is not respecting the unit schema.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Sep 21, 2022

@adrianinsaval I would expect the (m/kg/s/degree) unit system to display meters at all times, not only when the dimensions are close to 1 m. That's how it's done in other CAD software (like SolidWorks). Seeing mm displayed everywhere (for example the default 10 mm depth of extrusion) with MKS system enabled is really confusing. Maybe this request should be changed to something like "make the MKS system display meters regardless of the dimension value" instead.

@adrianinsaval
Copy link
Member

I see no reason why you would want to see 10mm as 0.01m, "other software does it" is not a very good argument (although it can be valid for some stuff). Can you give me an example of a situation where forcing m for every value is advantageous?

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Sep 22, 2022

Small dimensions displayed in meters may seem inconvenient but it's mainly about consistency (and clarity). Especially if you are going to show the dimensions to someone, then the units should be consistent according to the rules of engineering. I'm not a civil engineer but guys from that field would likely agree with me that the MKS system should show meters at all times.

@adrianinsaval
Copy link
Member

the problem with making MKS show in meters for values bellow 0.1m is that our default number of decimals is just 2 IIRC, meaning it'll get rounded a lot. Maybe we can make this range dependent on the configured number of decimals

@joaocoutojc
Copy link

In freecad version 0.21 rc the measurements below ten meters show in millimeters. Could be shown in millimeters measured smaller than 0.1m

@adrianinsaval
Copy link
Member

now that #9583 is merged this might be more feasible

@adrianinsaval
Copy link
Member

In freecad version 0.21 rc the measurements below ten meters show in millimeters. Could be shown in millimeters measured smaller than 0.1m

that would be when using the Standard unit system, MKS lowers this to values bellow 100mm as explained above.

WandererFan added a commit to WandererFan/FreeCAD that referenced this issue Nov 12, 2023
WandererFan added a commit to WandererFan/FreeCAD that referenced this issue Nov 14, 2023
WandererFan added a commit to WandererFan/FreeCAD that referenced this issue Nov 15, 2023
- use correct unit for velocity

- typo in include guard
wwmayer pushed a commit that referenced this issue Nov 15, 2023
- use correct unit for velocity

- typo in include guard
kpemartin pushed a commit to kpemartin/FreeCAD that referenced this issue Nov 20, 2023
- use correct unit for velocity

- typo in include guard
@furgo16
Copy link
Contributor

furgo16 commented Apr 16, 2024

Small dimensions displayed in meters may seem inconvenient but it's mainly about consistency (and clarity). Especially if you are going to show the dimensions to someone, then the units should be consistent according to the rules of engineering.

I agree with @FEA-eng's point. It is less about precision, but about consistency and predictability. I was quite confused when I set units to be m and measurements where displayed in mm. I just learned about the unwritten rule of switching to mm below 1 m measurements by trying to file an issue and stumbling upon this one. I would argue that if someone requires more precision below 1 m, they are already able to switch to the other cm or mm-based unit systems.

In addition, in FreeCAD 0.22 there is a new Meter decimal (m, m², m³) unit system that behaves under the expectations of this issue description. That is, measurements are always shown in m. I would also argue that to make those two unit systems (MKS and Meter decimal) also consistent with each other, units should always be in m..

After reading the full forum thread linked on the description, I understand that the Meter decimal (m, m², m³) unit system was added with the double purpose of adding the new functionality requested and of keeping the old functionality of the MKS system. While a good compromise, I would still argue that fixing the MKS system to follow the users' expectations (or at least from those voicing them on that thread), and having a shorter list of unit systems might be a simpler approach. Also one that could arguably be tested during the 0.22 development cycle, as no one on that thread seemed to advocate for keeping MKS as it is, with its automatic unit switching behavior.

@adrianinsaval
Copy link
Member

@WandererFan what do you think of the above? Is it really worth having a separate meters only system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature FR for improvements or new features Units Issue related to units of measurement
Projects
None yet
Development

No branches or pull requests

5 participants