[Units]Add Meters-only schema (#7395) #11365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Core
wwmayer
reviewed
Nov 13, 2023
src/Base/UnitsSchemaMeterDecimal.cpp
Outdated
| } | ||
| else if (unit == Unit::Velocity) { | ||
| // metres per second | ||
| unitString = QString::fromLatin1("m/sec"); |
There was a problem hiding this comment.
"sec" is not a valid SI unit. It must be "s" (https://en.wikipedia.org/wiki/Second). In case the faulty string is used in an expression an error is raised: App.Units.parseQuantity("2m/sec")
Traceback (most recent call last):
File "", line 1, in
ValueError: invalid unit expression
There was a problem hiding this comment.
unit string changed to "m/s".
WandererFan
force-pushed
the
metreSchema
branch
from
a40cbba
to
aaeb2bc
Compare
wwmayer
reviewed
Nov 14, 2023
src/Base/UnitsSchemaMeterDecimal.h
Outdated
| */ | ||
|
|
||
| #ifndef BASE_UNITSSCHEMAMETERS_H | ||
| #define BASE_UNITSSCHEMAMETERs_H |
There was a problem hiding this comment.
There is a typo. The #define is different to the #ifndef
- use correct unit for velocity - typo in include guard
WandererFan
force-pushed
the
metreSchema
branch
from
a78a00e
to
2cc6a5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a solution for #7395.
Additional forum discussion:
https://forum.freecad.org/viewtopic.php?t=71365
https://forum.freecad.org/viewtopic.php?t=59635