Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] DraftVecUtils.getPlaneRotation() returns scewed/scaled matrix #8697

Closed
2 tasks done
Jolbas opened this issue Feb 28, 2023 · 0 comments · Fixed by #8698
Closed
2 tasks done

[Issue] DraftVecUtils.getPlaneRotation() returns scewed/scaled matrix #8697

Jolbas opened this issue Feb 28, 2023 · 0 comments · Fixed by #8698

Comments

@Jolbas
Copy link
Contributor

Jolbas commented Feb 28, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Forums discussion

https://forum.freecad.org/viewtopic.php?t=76390

Version

0.21 (Development)

Full version info

OS: Ubuntu 20.04.5 LTS (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: recent master, see hash
Build type: Debug
Branch: master
Hash: 4adf98e369417e5c2cb00eef3eef8a76daa30011
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.3.0
Locale: English/United States (en_US)
Installed mods: 
  * 3DfindIT 1.2.0
  * Render 2023.2.0
  * BIM 2021.12.0
  * Reinforcement
  * Manipulator 1.5.0
  * Assembly4.backup1662941442.2770898
  * parts_library
  * Assembly4 0.12.5
  * fasteners 0.4.54
  * Help 1.0.3
  * Silk 1.0.0
  * dodo 1.0.0
  * Curves 0.6.7

Subproject(s) affected?

Draft

Issue description

DraftVecUtils.getPlaneRotation() does not return a pure rotation matrix unless u, v and w is perfectly perpendicular normalized vectors. If there is a scew matrix it is not accepted by App.Rotation(matrix) since bad52df.
This issue is affecting mostly draft dimensions but also some import functions.
See forum thread for test file

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant