Return pure rotation from getPlaneRotation() #8698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems good and indeed the correct way to handle it as if u and v are given, there is only one direction where w can be. |
Roy-043
reviewed
Apr 1, 2023
| self.u.y, self.v.y, self.axis.y, self.position.y, | ||
| self.u.z, self.v.z, self.axis.z, self.position.z, | ||
| 0.0, 0.0, 0.0, 1.0) | ||
| m = DraftVecUtils.getPlaneRotation(self.u, self.v) |
There was a problem hiding this comment.
This function is a bit strange now. The rotated argument is effectively ignored: if and else return the same result.
There was a problem hiding this comment.
Yes, it should have been
if rotated:
m = DraftVecUtils.getPlaneRotation(self.u, self.axis)
else rotated:
m = DraftVecUtils.getPlaneRotation(self.u, self.v)
Jolbas
added a commit
to Jolbas/FreeCAD
that referenced
this pull request
Apr 1, 2023
Roy-043
pushed a commit
that referenced
this pull request
Apr 2, 2023
fix for mistake in pr #8698 see comment https://github.com/FreeCAD/FreeCAD/pull/8698/files/649857b58f7b100242a2e948e07e11ff2fe64f67#r1155160709
Pesc0
pushed a commit
to Pesc0/FreeCAD
that referenced
this pull request
Apr 3, 2023
chennes
pushed a commit
to chennes/FreeCAD
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #8697. By normalizing vector u and make v and w perpendicularand normalized the returned matrix turns into a pure rotation without scales and shears. Using v vector to define xy plane. Leaves the third argument unused but keep it for backward compatibility.