Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Update gui_selectplane.py #11062

Merged
merged 1 commit into from Oct 17, 2023

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Oct 16, 2023

Related issue:
#5603

Previous PR:
#11010

  • This PR implements the new PlaneGui class for the Draft_SelectPlane command.
  • As mentioned in the previous PR, almost all working plane related code has been removed from gui_selectplane.py.
  • The task panel has a new button "Next" to switch to the next working plane in the history.
  • Both the "Previous" and "Next" buttons are only enabled if there is a corresponding step in the history.
  • PlaneGui stores a working plane per 3D view, but the other commands have to be updated before that system is fully functional.
  • Code to update the toolbar when switching to a different view will be added later.

Related issue:
FreeCAD#5603

Previous PR:
FreeCAD#11010

* This PR implements the new PlaneGui class for the Draft_SelectPlane command.
* As mentioned in the previous PR, almost all working plane related code has been removed from gui_selectplane.py.
* The task panel has a new button "Next" to switch to the next working plane in the history.
* Both the "Previous" and "Next" buttons are only enabled if there is a corresponding step in the history.
* PlaneGui stores a working plane per 3D view, but the other commands have to be updated before that system is fully functional.
* Code to update the toolbar when switching to a different view will be added later.
@Roy-043 Roy-043 added the WB Draft Related to the Draft Workbench label Oct 16, 2023
@yorikvanhavre yorikvanhavre merged commit cf9b342 into FreeCAD:main Oct 17, 2023
8 checks passed
@Roy-043 Roy-043 deleted the Draft-Update-gui_selectplane.py branch October 17, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants