Draft: improve handling of anno DisplayMode and LineSpacing #11550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roy-043
commented
Nov 27, 2023
Roy-043
commented
- DisplayMode controlled by new pref DefaultAnnoDisplayMode. This replaces the old dimstyle pref.
- LineSpacing pref is now used when creating annotations. Will be added to prefs ui later.
- format_object no longer changes FontSize as this conflicted with the height parameter in the make_text function.
- make_text function updated.
* DisplayMode controlled by new pref DefaultAnnoDisplayMode. This replaces the old dimstyle pref. * LineSpacing pref is now used when creating annotations. Will be added to prefs ui later. * format_object no longer changes FontSize as this conflicted with the height parameter in the make_text function. * make_text function updated.
Roy-043
deleted the
Draft-improve-handling-of-anno-DisplayMode-and-LineSpacing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.