GUI: Follow the widget indications when docking them #12530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overlay manager handles the creation and drawing of the title bars for the docked widgets. When adding a QDockWidget the manager ignored the set of features (closable, movable, floatable) provided by the widget and always showed all the actions. Amend the code to take into account the features specified by the widget. Closes FreeCAD#11944
github-actions
bot
added
the
Core
|
@LemonBoy please let me know if you plan on cherry-picking @kadet1090's commit here -- if you do that, I'd appreciate it if you'd squash the existing three commits into one. |
I don't think so, this PR is only making the overlay manager show the right set of buttons requested by the QDockWidget. |
|
Ping ? |
|
can someone check if this issue is related to this PR: |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlay manager handles the creation and drawing of the title bars for the docked widgets. When adding a QDockWidget the manager ignored the set of features (closable, movable, floatable) provided by the widget and always showed all the actions.
Amend the code to take into account the features specified by the widget.
Closes #11944
This commit makes the dockbars show the same set of buttons with and without the overlay mode enabled.
Random concern, should the "overlay" button be displayed unconditionally?