Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent Overlays: Panel names are always visible. Displayed twice when hovering #13349

Closed
2 tasks done
maxwxyz opened this issue Apr 7, 2024 · 16 comments · Fixed by #13838
Closed
2 tasks done

Transparent Overlays: Panel names are always visible. Displayed twice when hovering #13349

maxwxyz opened this issue Apr 7, 2024 · 16 comments · Fixed by #13838
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Regression Bugs describing a regression or PRs fixing one Status: confirmed The issue was confirmed by others UI/UX

Comments

@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

The title names of the panels / docked windows are always visible when using the transparent overlay mode:
grafik

When hovering the panels, they are even displayed twice. I'm not sure when this was added or why but a few weeks ago there were no default titles displayed as seen in a screenshot from #11794
292187312-8a13965e-b6d1-4340-8571-09284c732721

Full version info

OS: Windows 11 build 22631
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.36784 (Git)
Build type: Release
Branch: main
Hash: d1930fc7e6fc35c413f9f39d22f2ea28fca827c7
Python 3.11.8, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: German/Germany (de_DE)
Installed mods: 
  * 3DfindIT 1.2.0
  * BIM 2021.12.0
  * CfdOF 1.25.10
  * CurvedShapes 1.0.8
  * Curves 0.6.29
  * Defeaturing 1.2.2
  * fasteners 0.5.16
  * FEMbyGEN 2.1.0
  * freecad.gears 1.2.0
  * freecad_metal_workbench 0.0.1
  * kicadStepUpMod 11.1.0
  * lattice2 1.0.0
  * OpenDark 2023.12.17
  * Rocket 3.3.0
  * sheetmetal 0.4.10
  * Silk 0.1.5

Subproject(s) affected?

Core

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD UI/UX Regression Bugs describing a regression or PRs fixing one labels Apr 7, 2024
@maxwxyz maxwxyz changed the title Transparent Overlays: Panel names are always visible, when hovering twice Transparent Overlays: Panel names are always visible. Displayed twice when hovering Apr 7, 2024
@jag45
Copy link

jag45 commented Apr 7, 2024

This seems to have coincided with the following change:
WIP Wednesday

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Apr 7, 2024

@LemonBoy can you confirm? Previously the panel titles were not shown when transparency was enabled, and that how it should be IMO. Now they are always shown and even twice when hovering.
Also the close / dock buttons should not be shown as previously, only when hovering:
grafik

@PaddleStroke
Copy link
Contributor

PaddleStroke commented Apr 8, 2024

+1 I can reproduce.

  • Now we have 2 bars.
  • I agree the situation was better before. I do not see value of having the title bars displayed all the time. It was better when it shows only on hover.
  • The new bar looks better imo. But it lacks the settings button. It also lacks the resize handle.

Btw it would be better to remove the eye icon and the overlay icon and put these options in the 'settings' button.
image

@maxwxyz maxwxyz added the Status: confirmed The issue was confirmed by others label Apr 8, 2024
@jag45
Copy link

jag45 commented Apr 8, 2024

Tried with weekly 36228, only the one bar when you hover.
Tried with weekly 36277 (released 6th March), we have the situation above, ie. 2 bars.

As an aside , I cannot find lemonboy in the member list. However there is a lemonbug, (pretty close on the keyboard) so maybe the WIP Wednesday screenshot above has a typo on the user name.

@ayushgupta9906
Copy link

I want to work on this issue. Please Assign this to me.
Thanks

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Apr 19, 2024

@ayushgupta9906 any news on this?
@LemonBoy could you weigh in, was it introduced with your commit?

@MisterMakerNL
Copy link
Contributor

MisterMakerNL commented Apr 20, 2024

I just build the latest on Windows 10 had similar issue added a gif where it is visible here:
#12573 (which is probably related since it is also overlay UI stuff.)

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Apr 20, 2024

@kadet1090 could you support here?

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Apr 20, 2024

is #12530 to blame?

@MisterMakerNL
Copy link
Contributor

Double title seems to go away when you undock the widget, so maybe it has to do with:
OverlayManager::onDockVisibleChange
Or maybe it can be fixed with that function?

@kadet1090
Copy link
Contributor

@kadet1090 could you support here?

I'll look into that this week hopefully

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Apr 29, 2024

@kadet1090 do you need help with testing or anything else I could support?

kadet1090 added a commit to kadet1090/FreeCAD that referenced this issue May 5, 2024
@kadet1090
Copy link
Contributor

I fixed it in #13838, but only the issue with double header. Any remodeling of the header will need to be done in #11998 as current implementation is tape over tape...

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 5, 2024

nice, thanks!

@MisterMakerNL
Copy link
Contributor

Finally the double header it's gone! Tnxs!!!

@MisterMakerNL
Copy link
Contributor

Well it is fixed a bit sometimes :)
Needs some work!

adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Regression Bugs describing a regression or PRs fixing one Status: confirmed The issue was confirmed by others UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants