-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce object freeze #12580
Introduce object freeze #12580
Conversation
@wwmayer you're right about |
@obelisk79 can the DWG take a look at this? |
I am somewhat confused what the purpose of this PR/Feature is. Is the intent to 'freeze' an object to save resources on recomputes? The referenced issue was closed as 'not planned'. The original mantis ticket referenced some forum posts where the issue wasn't 100% clear to me. |
I like this feature. Many objects (TechDraw views, Draft Shape2DViews...) have introduced their own "turn off recomputing" system over time. This is an excellent FreeCAD-wide system IMHO. @obelisk79 indeed some features, such as those I mentioned here, often depend on a lot more objects (half of your model usually...) and they are slow to recompute. So it turns your workflow VERY slow, like, each time you move something there is a big recompute, and it's a common thing to "turn them off" while you're not using them actively. With a FreeCAD-wide system I can imagine much better tools and workflows to for ex automatically freeze/unfreeze series of objects, add this to Draft layers, etc... |
The question is whether there is a need to only temporarily switch off the parametric behaviour of an object. If the removal of the parametric behaviour is permanent then a simple copy will do it but if it should be enabled again then a simple copy is not sufficient. About the recently added suppress feature function I don't know what the exact difference should be. At least compared to the suppress feature function the method of this PR has no extra memory costs. |
My own explanation about Suppress vs. Freeze:
@wwmayer SimpleCopy only acts on shape when a freezed object is really immutable. And the freeze sate can be switched off which avoids having to redo an object. |
Merging it as we feel the questions are responded and we're happy with the feature. |
@FlachyJoe Is it normal that I can find the Toggle freeze option in the context menu only when I'm in the Part workbench, not in Part Design ? Interestingly, it can be applied from Part to PD features.
|
@FEA-eng no, it isn't. Thank you. |
@FlachyJoe to add to @FEA-eng comment I've added more problems to this issue: #12829 |
@FlachyJoe @yorikvanhavre not sure if this as merged functions as intended. If the intention is just temporarily disable recompute but do whatever you want with the object than it should be renamed but than it does not resolve the issue from the linked forum discussion as I understand. |
Fix #5545 Switch on and off parametric behaviour of document objects