Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: support toolbar drag and drop to status bar and menu bar #13571

Merged
merged 5 commits into from
May 6, 2024

Conversation

realthunder
Copy link
Collaborator

Closes #12979

@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Apr 21, 2024
@PaddleStroke
Copy link
Contributor

PaddleStroke commented Apr 22, 2024

Thanks for bringing in these changes !

Few issues I have noticed :
1 - The sketcher 'edit mode' toolbar are present all the time in all workbenches :
image
The only way to remove them is to edit a sketch, which hides them. Then they stay gone until restart.

2 - There is no way to remove toolbar from the menubar. Once a toolbar is dropped in there it cannot be removed. We would need at least the same menu as in the status bar 'Unlock toolbar':
image

3 - The tabbar is oriented South instead of North when dropped in the menu bar :
image

4 - The tools icon size is relatively big compared to the menu and tabbar which does not look great :
image
Maybe there are some paddings or margins that could be removed. Or alternatively reducing the icons from 24 to 20px when in menubar or status bar? Here how it would look with 20 px icons :
image

5 - When dragging to the menubar, if the mouse is too close to the window border, things get weird :
image
And can get even more weird on some occasions :
image

@realthunder
Copy link
Collaborator Author

Add a few fix, please check again.

@PaddleStroke
Copy link
Contributor

PaddleStroke commented Apr 30, 2024

Thanks!
1, 2, 4 and 5 are fixed.

  • 3 is not fixed yet. I think it's just the tab bar that defaults to south so this should be easily fixed.

One more small things :
6 - the preference 'Workbench Selector Position' needs to be removed.
image

  • Currently if your position preference is set to right corner, the workbench toolbar does not appear at all, you need to set it back to toolbar and reboot. So if you remove the setting, don't forget to remove where the preference is used as well.

@realthunder
Copy link
Collaborator Author

More fix. Please check again.

@PaddleStroke
Copy link
Contributor

Thanks all fixed now!

@yorikvanhavre yorikvanhavre merged commit c24ace7 into FreeCAD:main May 6, 2024
8 of 9 checks passed
@Syres916
Copy link
Contributor

@realthunder please see https://forum.freecad.org/viewtopic.php?p=758767#p758767 regarding new users regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status bar is not customizable.
4 participants