Test: Support system GTest, and give warning if no submodule #13662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could use a Linux user with GTest installed on their system to test deleting the tests/lib subdirectory (which is the GTest submodule installation) and let me know if the test compilation proceeds correctly. |
|
Tested and got this at -- Found GTest: /lib/x86_64-linux-gnu/cmake/GTest/GTestConfig.cmake (found version "1.14.0")
-- Found Google Test: version 1.14.0
CMake Error at tests/CMakeLists.txt:121 (add_subdirectory):
add_subdirectory given source "lib" which is not an existing directory. |
chennes
force-pushed
the
gitSubmoduleMissingWarning
branch
from
c454dc8
to
87049b6
Compare
|
I'll try to review as well |
|
I deleted the tests/lib directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code similar to that for GSL, that checks for the existence of the GTest submodule, and if it doesn't find it tries to find a system-installed version before printing an error about needing a submodule update. Still needs testing on Linux with GTest installed on the system.