UI: Unify document icons according to artwork guidelines

[maxwxyz]

Problem:

Multiple icons for documents across FreeCAD.

This PR unifies document icons.
@FreeCAD/design-working-group FYI
@marcuspollio FYI regarding BIM overhaul

[MisterMakerNL]

I think this is some great work!
I have something against sun in the new icon, but that is probably another discussion.

[marcuspollio]

Great, nice work, thanks Max !

Some comments for this PR, I would :

• Std_Export.svg : make the red arrow exit on the right like many other softwares (Libreoffice, Inkscape, Scribus, etc). Not great for Arabic, Aramaic, Hebrew, Persian languages tough...
• Std_Import.svg : make the green arrow enter from the left (idem). Or do it the Blender and KiCAD way (top-down, bottom-up).
• Std_PrintPdf.svg : either use the full trefoil of Adobe Acrobat (Libreoffice, Scribus... IMHO I wouldn't) but comply with these rules, or write "PDF" in the document icon (the name is royalty-free). In its current state, we can guess what this icon means but it's not balanced visually and made-up. If you go the PDF letters way, black instead of red can work.
• Same disposition for all "double-document" icons : the front one slightly on the lower-left, the back one slightly on the upper-right. Like Std_MergeProjects.svg and Std_SaveCopy.svg. Unlike Std_RecentFiles.svg, Std_RecentMacros.svg and preferences-import-export.svg
• Std_RecentFiles.svg, Std_RecentMacros.svg : is the blue arrow really needed ?
• Document-new.svg : I'm not fond of the yellowish sun either, a "+" would do for me, but it's more a matter of taste, so no big deal.

In later PR, I would :

• Make all eyes in icons consistent. The ones in Std_HideObjects.svg, Std_ShowObjects.svg and Std_ToggleObjects.svg are quite bad TBH.
• Improve all addons manager and workbenches icons with the brown box/crate : simpler and consistent outlines
• I have a doubt about all "save" icons, as on my system (Gnome desktop environment), they're overridden and the ones in the FreeCAD source are different. I would just make sure they're consistent and use a lighter grey than on your floppy disk (more like the printer).
• If the FreeCAD logo changes, there will still be some adjustments to some of this PR icons (for later anyways)
• Do we keep the blue Part stretched so ? The one in tree-doc-*.svg looks better IMHO.

[Reqrefusion]

I'm glad we feel similarly. Must have changes.
The total area of some icons has different distances from the corners. In addition, the size of 60x60 is too large and for a square layout it needs to be 54x54 to cover an equal area. It would be much better if it was fixed this way.

[maxwxyz]

@marcuspollio @Reqrefusion Thank you for the feedback, I've updated the icons accordingly!
Regarding spacing: Document icon is centered and arrows go in/out accordingly, the icons are directly above each other so an offset document looks off. And I won't make the document a square just to cover equal rectangular space. It's just a slight adjustment based on current icons to be more consistent.
Indeed they will be updated with a new logo, maybe I go over more in the next step and polish the rest.

PR is ready.

[Reqrefusion]

@marcuspollio @Reqrefusion Thank you for the feedback, I've updated the icons accordingly! Regarding spacing: Document icon is centered and arrows go in/out accordingly, the icons are directly above each other so an offset document looks off. And I won't make the document a square just to cover equal rectangular space. It's just a slight adjustment based on current icons to be more consistent. Indeed they will be updated with a new logo, maybe I go over more in the next step and polish the rest.

PR is ready.

I guess I couldn't explain it, I'm talking about square area in general. For example, the Std_SaveAll.svg icon covers an area of 60x60. Vertical rectangular icons occupy a space of 48x60. Square icons should be 54x54 in order to have equal space coverage. Accordingly, you need to resize Std_SaveAll.svg, document-open.svg, print-preview.svg, document-print.svg. You can resize document-save-as.svg, document-save.svg, list-add.svg, list-remove.svg, preferences-import-export.svg if you want. In fact, the area covered by icons is a very important and sensitive issue. It is a pity that there is nothing about this in the guide, but it is a general rule so it would be good to be careful.

48x60 icons occupy 2880 units. 54x54 icons occupy 2916 units. The 60x60 icon occupies 3600 units. These differences prevent the icons from having a certain order.

I don't think the PR is ready until the size issue is solved.

[marcuspollio]

PR is ready.

Thanks ! LGTM

[FEA-eng]

Great. I especially like the new save icons which are finally classic floppy disks and not just arrows pointing towards something looking more like old game console.

However, the Zoom All icon is going to be replaced with just a magnifying glass with arrows inside in another PR so can you remove it from this PR?