Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: update assembly icons to be consistent with main updates #13866

Merged
merged 1 commit into from
May 20, 2024

Conversation

maxwxyz
Copy link
Collaborator

@maxwxyz maxwxyz commented May 7, 2024

Consistency following #13865

  • update assembly icons to be consistent with main updates
  • add commands to menu/toolbar.

@github-actions github-actions bot added the WB Assembly Related to the Integrated Assembly Workbench label May 7, 2024
@Reqrefusion

This comment was marked as resolved.

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 8, 2024

Adjusted to match icon in main.

@Reqrefusion

This comment was marked as resolved.

@chennes chennes requested a review from PaddleStroke May 13, 2024 15:50
@chennes
Copy link
Member

chennes commented May 13, 2024

@PaddleStroke these features are ready to be out of "experimental stage"?

@PaddleStroke
Copy link
Contributor

PaddleStroke commented May 14, 2024

I would recommend that the features are left in experimental stage for about 2-3 months so that they can be tested by power users to make sure we iron out any outstanding issues.

And thanks for the icons update!

@FEA-eng
Copy link
Contributor

FEA-eng commented May 14, 2024

I would recommend that the features are left in experimental stage for about 2-3 months so that they can be tested by power users to make sure we iron out any outstanding issues.

But this means that they will be available but not visible in the next stable release the whole time so most regular users (who often discover bugs thanks to extensive usage) won't have a chance to test them. Maybe at least add an easier way to activate them (like a preference) for those users?

@chennes
Copy link
Member

chennes commented May 14, 2024

Considering that Ondsel has these enabled in their recent release, it seems like that are stable enough for general use (or if they are not, then we do need to get them in front of users ASAP if we hope to have them in the 1.0 release)

@chennes chennes merged commit 748306d into FreeCAD:main May 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Assembly Related to the Integrated Assembly Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants