Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DAE export of groups including sub-groups and sub-parts #1565

Merged
merged 2 commits into from Jul 27, 2018

Conversation

ptenbrock
Copy link

Previously, the DAE file export for a selected group ended in an error message (variable vindex undefined). Now, all children of the group will be added as objects to be exported.

If objects in a group with a non-default Placement were exported, the placement in the resulting file was incorrect (the placement of the parent groups was ignored). This is now fixed.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR is merged.


@yorikvanhavre yorikvanhavre merged commit 4c188ec into FreeCAD:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants