Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: fix double translation in Draft._PointArray #2657

Merged
merged 1 commit into from Oct 25, 2019

Conversation

vocx-fc
Copy link
Contributor

@vocx-fc vocx-fc commented Oct 24, 2019

The nshape.translate() operation is called twice, once inside if hasattr(pts, 'Placement'), and once outside. This results in incorrectly spaced arrays.

We put the second translation in an else clause, so that only one translation is executed.

See forum thread for pictures: Bug: Draft PointArray uses points with twice the spacing


  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

@yorikvanhavre yorikvanhavre merged commit c940269 into FreeCAD:master Oct 25, 2019
@vocx-fc vocx-fc deleted the fix_double_translate branch October 25, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants