Part: Offset2D: fix save-load instability (bug #2699) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes FreeCAD#2699 It was found out that when direction of normal found by FindPlane depends on if we are using result of offset directly, or after copying. The fix (workaround) is to copy offset result inside offset routine, so that no unstable behavior makes its way to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2699
It was found out that when direction of normal found by FindPlane
depends on if we are using result of offset directly, or after copying.
The fix (workaround) is to copy offset result inside offset routine, so
that no unstable behavior makes its way to the user.
http://www.freecadweb.org/tracker/view.php?id=2699
http://forum.freecadweb.org/viewtopic.php?f=3&t=17449