Reduce demo icon theme #2940
Merged
Reduce demo icon theme #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigate an issue with scaled icons as discussed: https://forum.freecadweb.org/viewtopic.php?f=10&t=28838&p=363487#p363487
|
Isn't this PR bettering things for some, but worsening for others? (Removing theme support) |
|
This PR doesn't remove icon theme support. There is a demo theme embedded in FreeCAD and it's set to ON by default, named FreeCAD-default. There are only a few icons added to it, but they are the exact same icons that are used as a "fallback". Therefore if this theme is set to ON or OFF the icons will still look the same. I left one icon in it for demonstration purposes, on how can an icon theme be embedded in FreeCAD. And it is a good thing to have such option, for still being able to enable such icon theme on Linux, when you want to override the system default one. As seen in this PR: |
|
Understood. Ok then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate an issue with scaled icons as discussed:
https://forum.freecadweb.org/viewtopic.php?f=10&t=28838&p=363487#p363487