[Gui] New Icons and rearrangement of Draw Style menu #3119
Conversation
carlopav
changed the title
|
I see you have changed the command object names. In that case i will have to update the macros: https://forum.freecadweb.org/viewtopic.php?f=3&t=14336&start=50#p364692 P.S. Not a big deal, just wondering if it is necessary to change the object names in addition to changing the icons. |
Hmmm this was not my intention, I just wanted them to appear in the menu in the order from the most simple (points) to the most complete (flat lines), so I thought to re-order them in every list of the file, but I probably did something wrong... |
|
My bad. You didn't use different object names, you have just moved them around a bit. In that case the mentioned macros should continue to work just fine. Sorry for the noise. |
|
Anyway, if you know someone who can test it and correct whatever needed, feel free to add him to the conversation :) |
src/Gui/CommandView.cpp
Outdated
| a6->setCheckable(true); | ||
| a6->setIcon(BitmapFactory().iconFromTheme("DrawStyleWireFrame")); | ||
| a6->setObjectName(QString::fromLatin1("Std_DrawStyleNoShading")); | ||
| a1->setCheckable(true); |
There was a problem hiding this comment.
Likely this should be a6 instead of a1.
|
In general it looks OK to me. I added a note, as one line needs changing. I see you have already discussed the proposed change on the forum. P.S. After you will update the PR best to change the title to indicate this PR is ready to be merged. |
Just an experiment, didn't try to compile Gui: Changed icons in Draw Style menu And also saved old icons in pure svg.
carlopav
force-pushed
the
GuiReorderDrawStyle
branch
from
6fafdc3
to
b9c117a
Compare
|
Good catch! i updated and rebased, but the point is that i didn't try to compile it... do you think it's safe to merge it anyway? |
|
Travis will compile it for you. https://travis-ci.org/FreeCAD/FreeCAD/builds/659359801?utm_source=github_status&utm_medium=notification |
|
One additional thing, beyond changing the title, you should do is to add newly introduced icon (DrawStyleHiddenLine.svg) to: https://github.com/FreeCAD/FreeCAD/blob/master/src/Gui/Icons/resource.qrc The rest looks OK to me. Reference: |
carlopav
force-pushed
the
GuiReorderDrawStyle
branch
from
b9c117a
to
cf70982
Compare
carlopav
changed the title
Just an experiment, didn't try to compile
Gui: Changed icons in Draw Style menu
And also saved old icons in pure svg.