Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not tested with Python 2.7] [AddonManager] Support for UTF8 characters in macros #3289

Merged
merged 2 commits into from Apr 1, 2020

Conversation

0penBrain
Copy link
Contributor

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

Add support for macros with UTF8 encoded characters by always writing macro code in an UTF8 file.
Also fix a bug in Execute function

I can't test with Python 2.7. Best if one can do it before merging.

@yorikvanhavre
Copy link
Member

Would be better to test with py2 before merging then... Otherwise it can cause some headache later on if users complain

@0penBrain
Copy link
Contributor Author

@yorikvanhavre : I made a quick test based on my 0.18.4 that uses Python 2.7. It returns error on macros using Unicode characters, but this doesn't come from the modification. Actually, the PR doesn't solve UTF8 problem with Python 2.7 but it doesn't make the thing worse than currently. ;)

@yorikvanhavre
Copy link
Member

Okay let's merge then... We'll solve further if people complain

@yorikvanhavre yorikvanhavre merged commit 943eedb into FreeCAD:master Apr 1, 2020
@0penBrain 0penBrain deleted the addonManager branch February 25, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants