Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: small fix for older PathArray objects #3519

Merged
merged 1 commit into from May 29, 2020

Conversation

vocx-fc
Copy link
Contributor

@vocx-fc vocx-fc commented May 27, 2020

Older PathLinkArray objects had a useLink attribute which was migrated to use_link. A recent commit, ff323eb, made some improvements to the PathArray object, but broke the migration of the property.

This fixes the migration, so that now all objects should open correctly.

A previous attempt was #3508.


  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

Older PathLinkArray objects had a `useLink` attribute
which was migrated to `use_link`. A recent commit, ff323eb,
made some improvements to the PathArray
object, but broke the migration of the property.

This fixes the migration, so that now all objects should
open correctly.
@yorikvanhavre yorikvanhavre merged commit 547b9e4 into FreeCAD:master May 29, 2020
@vocx-fc vocx-fc deleted the Draft_quick_fix_PathArray branch May 29, 2020 14:54
@vocx-fc vocx-fc mentioned this pull request May 31, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants