Draft: add some explanation on the properties of PathArray #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vocx-fc
force-pushed
the
Draft_PathArray_note
branch
from
eb7e4d8
to
6914f1a
Compare
The use of `App::PropertyLinkSubList` for `'PathSubelements'` is a mistake because we could use a single `App::PropertyLinkSub` to handle both `'PathObject'` and `'PathSubelements'` properties. This commit doesn't change any code, it just adds comments explaining the situation so that it is not forgotten, and we remember to address it in the future. Ideally we should migrate the objects, but we may also decide to break compatibility with older `PathArrays` if both properties can't be migrated easily.
vocx-fc
force-pushed
the
Draft_PathArray_note
branch
from
6914f1a
to
d2858ef
Compare
|
@WandererFan It's not necessary to do anything at the moment, but it's just something that I'd change at some point in the future. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
App::PropertyLinkSubListforPathSubelementsis a mistake because we could use a singleApp::PropertyLinkSubto handle bothPathObjectandPathSubelements.This commit doesn't change any code, it just adds comments explaining the situation so that it isn't forgotten, and we remember to address it in the future. Ideally we should migrate the objects, but we may also decide to break compatibility with older
PathArraysif both properties can't be migrated easily.See Making the creation of arrays more user friendly.
git pull --rebase upstream master./bin/FreeCAD --run-test 0issue #<id>orfixes #<id>where<id>is the associated MantisBT issue id if one exists