Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artwork vulture pass #398

Closed
wants to merge 5 commits into from
Closed

Conversation

agryson
Copy link
Contributor

@agryson agryson commented Dec 26, 2016

Alignment of multiple workbenches to the Tango guidelines.

Forum discussion

Forum Pull Request

Workbenches updated:
* Complete
* Image
* Inspection
* Material
* MeshPart
* Points
* Reverse Engineering
* Start
* Test
* Web
@agryson
Copy link
Contributor Author

agryson commented Dec 26, 2016

Could someone explain why this build failed? I only touched svg's and the build log suggests all is well... is it from a commit in master that I rebased onto?

@agryson
Copy link
Contributor Author

agryson commented Dec 26, 2016

Though I see something about grepping logs at the end that didn't exit right...

@agryson
Copy link
Contributor Author

agryson commented Dec 26, 2016

Found error but don't understand how my commits could cause it:

======================================================================

ERROR: testBoxCase (TestPartDesignApp.PartDesignPadTestCases)

----------------------------------------------------------------------

Traceback (most recent call last):

File "/usr/local/FreeCAD.app/Contents/Mod/PartDesign/TestPartDesignApp.py", line 36, in testBoxCase

TestSketcherApp.CreateSlotPlateSet(self.PadSketch)

File "/usr/local/FreeCAD.app/Contents/Mod/Sketcher/TestSketcherApp.py", line 64, in CreateSlotPlateSet

SketchFeature.setDatum(11,0.000000)

ValueError: Cannot set the datum because the sketch contains conflicting constraints

----------------------------------------------------------------------

Ran 84 tests in 19.660s

FAILED (errors=1)

The command "${INSTALLED_APP_PATH} --run-test 0" exited with 1.

0.00s$ ${INSTALLED_APP_PATH} --log-file /tmp/FreeCAD_installed.log &

@yorikvanhavre
Copy link
Member

These errors must come from one of the latest commits before yours... I'll merge your branch manually

@yorikvanhavre
Copy link
Member

merged

@agryson
Copy link
Contributor Author

agryson commented Dec 26, 2016

Thanks for the merge, hope we find what was wrong!

@agryson agryson mentioned this pull request Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants